fix(projects): close review authorization and error gaps

src/main/resources/templates/projects/detail.html

@@ -5,7 +5,8 @@
 <main>
   <h1 th:text="${project.name}">Project</h1>
   <p th:text="${project.description}"></p>
-  <dl><dt>Status</dt><dd th:text="${project.status}"></dd><dt>Mentor</dt><dd th:text="${project.mentorName}"></dd><dt>Leader</dt><dd th:text="${project.leaderName}"></dd></dl>
+  <p role="alert" th:if="${projectError}" th:text="${projectError}"></p>
+  <dl><dt>Status</dt><dd th:text="${project.status}"></dd><dt>Mentor</dt><dd th:text="${project.mentorName}"></dd><dt>Leader</dt><dd th:text="${project.leaderName ?: 'No current Leader'}"></dd></dl>
   <form th:if="${project.canManage and project.status == 'PLANNED'}" th:action="@{/projects/{id}/activate(id=${project.id})}" method="post">
     <button type="submit">Activate</button>
   </form>

src/main/resources/templates/projects/form.html

@@ -5,11 +5,13 @@
 <main>
   <h1>Create Project</h1>
   <form method="post" th:action="@{/projects}" th:object="${projectForm}">
+    <p role="alert" th:if="${#fields.hasAnyErrors()}">Please correct the highlighted Project details.</p>
     <label for="name">Name</label><input id="name" th:field="*{name}" required maxlength="160">
     <p th:errors="*{name}"></p>
     <label for="description">Description</label><textarea id="description" th:field="*{description}"></textarea>
     <label for="startDate">Start date</label><input id="startDate" type="date" th:field="*{startDate}" required>
     <label for="endDate">End date</label><input id="endDate" type="date" th:field="*{endDate}" required>
+    <p th:errors="*{dateRangeValid}"></p>
     <label for="leader">Initial Leader user ID</label><input id="leader" type="number" min="1" th:field="*{initialLeaderUserId}" required>
     <p th:errors="*{initialLeaderUserId}"></p>
     <button type="submit">Create Project</button>

src/main/resources/templates/projects/leadership.html

@@ -7,7 +7,12 @@
   <table><caption>Leadership history</caption><thead><tr><th scope="col">Leader</th><th scope="col">Started</th><th scope="col">Ended</th></tr></thead>
     <tbody><tr th:each="term : ${leadership}"><td th:text="${term.leaderName}"></td><td th:text="${term.startedAt}"></td><td th:text="${term.endedAt}"></td></tr></tbody>
   </table>
-  <form th:if="${project.canManage}" method="post" th:action="@{/projects/{id}/leadership(id=${project.id})}"><label for="leader">New Leader user ID</label><input id="leader" name="internUserId" type="number" min="1" required><button type="submit">Change Leader</button></form>
+  <form th:if="${project.canManage}" method="post" th:action="@{/projects/{id}/leadership(id=${project.id})}" th:object="${projectMemberForm}">
+    <p role="alert" th:if="${#fields.hasAnyErrors()}">Please correct the Leader selection.</p>
+    <label for="leader">New Leader user ID</label><input id="leader" th:field="*{internUserId}" type="number" min="1" required>
+    <p th:errors="*{internUserId}"></p>
+    <button type="submit">Change Leader</button>
+  </form>
 </main>
 </body>
 </html>

src/main/resources/templates/projects/members.html

@@ -7,7 +7,12 @@
   <table><caption>Membership history</caption><thead><tr><th scope="col">Intern</th><th scope="col">Joined</th><th scope="col">Left</th><th scope="col">Role</th></tr></thead>
     <tbody><tr th:each="member : ${members}"><td th:text="${member.displayName}"></td><td th:text="${member.joinedAt}"></td><td th:text="${member.leftAt}"></td><td th:text="${member.currentLeader} ? 'Leader' : 'Member'"></td></tr></tbody>
   </table>
-  <form th:if="${project.canManage}" method="post" th:action="@{/projects/{id}/members(id=${project.id})}"><label for="intern">Intern user ID</label><input id="intern" name="internUserId" type="number" min="1" required><button type="submit">Add member</button></form>
+  <form th:if="${project.canManage}" method="post" th:action="@{/projects/{id}/members(id=${project.id})}" th:object="${projectMemberForm}">
+    <p role="alert" th:if="${#fields.hasAnyErrors()}">Please correct the member selection.</p>
+    <label for="intern">Intern user ID</label><input id="intern" th:field="*{internUserId}" type="number" min="1" required>
+    <p th:errors="*{internUserId}"></p>
+    <button type="submit">Add member</button>
+  </form>
 </main>
 </body>
 </html>